New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send isMainFrame as argument to did-navigate-in-page event #6810

Merged
merged 2 commits into from Aug 12, 2016

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Aug 11, 2016

This fixes #6808

MarshallOfSound added some commits Aug 11, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 12, 2016

👍

@zcbenz zcbenz merged commit 6a7c6ca into master Aug 12, 2016

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #2180 succeeded in 6 min 19 sec
Details
electron-osx-x64 Build #2180 succeeded in 7 min 51 sec
Details
electron-win-ia32 Build #1204 succeeded in 6 min 24 sec
Details
electron-win-x64 Build #1188 succeeded in 6 min 32 sec
Details

@zcbenz zcbenz deleted the iframe-ismainpage-event branch Aug 12, 2016

HyunmoAhn added a commit to AhKi/oh-my-desk that referenced this pull request Oct 13, 2018

Block to change url when isMainFrame is false.
using isMainFrame boolean in 'did-navigate-in-page' event.
[ref](electron/electron#6810)
need to more information about isMainFrame if when is set false.

when access `google.com`, google redirect `notification.google.com/...` page.
So It will occur isMainFrame === false in params of did-navigate-in-page.

HyunmoAhn added a commit to AhKi/oh-my-desk that referenced this pull request Oct 24, 2018

Block to change url when isMainFrame is false.
using isMainFrame boolean in 'did-navigate-in-page' event.
[ref](electron/electron#6810)
need to more information about isMainFrame if when is set false.

when access `google.com`, google redirect `notification.google.com/...` page.
So It will occur isMainFrame === false in params of did-navigate-in-page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment