Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix intermittent crash in RemoteObjectFreer #6832

Merged
merged 3 commits into from Aug 17, 2016

Conversation

Projects
None yet
3 participants
@adill
Copy link
Contributor

adill commented Aug 12, 2016

this caches the render view's routing_id in the RemoteObjectFreer constructor so we can look it up later in RunDestructor with no v8 calls. this is a speculative fix for #6813 -- we can't reproduce it in-house and i don't have enough data yet to know if it's fixed in the wild but i wanted to open it up to discussion.

@zcbenz

@adill adill referenced this pull request Aug 12, 2016

Closed

renderer crash during GC #6813

@adill

This comment has been minimized.

Copy link
Contributor Author

adill commented Aug 15, 2016

haven't seen this issue in crash dumps all weekend since the fix went live.

@bridiver

This comment has been minimized.

Copy link
Contributor

bridiver commented Aug 16, 2016

I believe this also fixes a memory leak. GetCurrentRenderView sometimes returns null in the current code when this change is still able to get a valid reference through the routing_id_

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Aug 17, 2016

Thanks!

@zcbenz zcbenz merged commit bd03ae5 into electron:master Aug 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adill adill deleted the discordapp:bug/remote_object_freer_crash branch Aug 17, 2016

bridiver referenced this pull request in brave/muon Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.