New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all resizes when changing the window's style mask #6850

merged 2 commits into from Aug 17, 2016


None yet
2 participants

kevinsawicki commented Aug 15, 2016

Previously the ScopedDisableResize helper was only used when changing the resizable state, but it looks like unintentional resize also occurs when changing the minimizable, maximizable, and closable states.

This pull request moves the ScopedDisableResize into SetStyleMask to prevent unintended resize in all cases.

It also overrides setFrame since constrainFrameRect does not appear to be called for hidden windows which were also unintentionally resizing previously.

Closes #6845

@kevinsawicki kevinsawicki changed the title from Disable all resizes when changing the stylemask to Disable all resizes when changing the window's style mask Aug 15, 2016


This comment has been minimized.


zcbenz commented Aug 17, 2016


@zcbenz zcbenz merged commit 79f35fa into master Aug 17, 2016

7 of 8 checks passed

electron-win-ia32 Build #1217 failed in 6 min 20 sec
continuous-integration/travis-ci/pr The Travis CI build passed
electron-linux-arm Build #3854418 succeeded in 47s
electron-linux-ia32 Build #3854419 succeeded in 43s
electron-linux-x64 Build #3854420 succeeded in 80s
electron-mas-x64 Build #2191 succeeded in 7 min 21 sec
electron-osx-x64 Build #2192 succeeded in 7 min 54 sec
electron-win-x64 Build #1199 succeeded in 6 min 28 sec

@zcbenz zcbenz deleted the disable-resize-when-changing-style-mask branch Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment