New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent web contents in hidden windows from reporting as focused #6851

Merged
merged 2 commits into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 15, 2016

Looks like on Windows (and possibly Linux), a web content's render widget host view can report as focused even when in a hidden window.

This pull request adds a check to prevent hidden window's from having focused web contents. This mirrors the key window check already in the Mac implementation.

Closes #6811

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 17, 2016

👍

@zcbenz zcbenz merged commit 4e35535 into master Aug 17, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3855105 succeeded in 54s
Details
electron-linux-ia32 Build #3855106 succeeded in 49s
Details
electron-linux-x64 Build #3855107 succeeded in 86s
Details
electron-mas-x64 Build #2193 succeeded in 7 min 31 sec
Details
electron-osx-x64 Build #2194 succeeded in 7 min 49 sec
Details
electron-win-ia32 Build #1219 succeeded in 6 min 20 sec
Details
electron-win-x64 Build #1201 succeeded in 6 min 24 sec
Details

@zcbenz zcbenz deleted the focused-web-contents-from-hidden-windows branch Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment