New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing remote function properties #6867

Merged
merged 9 commits into from Aug 31, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 16, 2016

This pull request adds support for accessing the properties on a remote function when using remote.require.

It wraps remote functions in a Proxy object so properties on those functions are accessed over IPC and lazily loaded.

Closes #6863
Refs #4957

@kevinsawicki kevinsawicki changed the title from Allow accessing remote function properties to [WIP] Allow accessing remote function properties Aug 17, 2016

@kevinsawicki kevinsawicki changed the title from [WIP] Allow accessing remote function properties to Allow accessing remote function properties Aug 17, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 31, 2016

👍

@zcbenz zcbenz merged commit f854b27 into master Aug 31, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3920528 succeeded in 52s
Details
electron-linux-ia32 Build #3920529 succeeded in 46s
Details
electron-linux-x64 Build #3920530 succeeded in 85s
Details
electron-mas-x64 Build #2256 succeeded in 7 min 14 sec
Details
electron-osx-x64 Build #2262 succeeded in 7 min 46 sec
Details
electron-win-ia32 Build #1270 succeeded in 6 min 30 sec
Details
electron-win-x64 Build #1254 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the remote-function-properties branch Aug 31, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 31, 2016

Sorry for the late review, it somehow fell out of my list.

@wadjeroudi

This comment has been minimized.

wadjeroudi commented Mar 6, 2017

@kevinsawicki Hey, do you know if with your new Proxy method we can add property to remote object ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment