Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scoped policy for micro tasks #6926

Merged
merged 2 commits into from Aug 22, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Copy link
Member

zcbenz commented Aug 22, 2016

This fixes #6830 which was introduced by #6707.

V8 5.2 has some compatibility mode for SetAutorunMicrotasks, so either calling it with true or false would make V8 use a different mode from blink. This PR makes V8 use SetMicrotasksPolicy(v8::MicrotasksPolicy::kScoped) in renderer process, so it is not crashing and does not revert the previous bug.

@zcbenz zcbenz merged commit d6a6385 into master Aug 22, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3910336 succeeded in 53s
Details
electron-linux-ia32 Build #3910337 succeeded in 47s
Details
electron-linux-x64 Build #3910338 succeeded in 86s
Details
electron-mas-x64 Build #2243 succeeded in 7 min 43 sec
Details
electron-osx-x64 Build #2249 succeeded in 6 min 34 sec
Details
electron-win-ia32 Build #1257 succeeded in 6 min 24 sec
Details
electron-win-x64 Build #1241 succeeded in 6 min 33 sec
Details

@zcbenz zcbenz deleted the fix-fetch branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.