New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default network conditions to 0.0 #6935

Merged
merged 3 commits into from Aug 23, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 22, 2016

Default throttling values to 0.0 so DevToolsNetworkConditions::IsThrottling will return the expected value when they are unspecified.

Closes #6928

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 23, 2016

👍

@zcbenz zcbenz merged commit 4ca6587 into master Aug 23, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3920070 succeeded in 53s
Details
electron-linux-ia32 Build #3920071 succeeded in 48s
Details
electron-linux-x64 Build #3920072 succeeded in 84s
Details
electron-mas-x64 Build #2254 succeeded in 7 min 15 sec
Details
electron-osx-x64 Build #2260 succeeded in 6 min 39 sec
Details
electron-win-ia32 Build #1268 succeeded in 6 min 22 sec
Details
electron-win-x64 Build #1252 succeeded in 6 min 35 sec
Details

@zcbenz zcbenz deleted the default-network-conditions branch Aug 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment