New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol: allow standard schemes to support filesystem api #6952

Merged
merged 4 commits into from Aug 25, 2016

Conversation

Projects
None yet
3 participants
@deepak1556
Member

deepak1556 commented Aug 24, 2016

It isn't necessary for the scheme to be standard for accessing filesystem api, but the registeration has to happen during context creation which means to add another api to protocol for use before ready event. Would it be better to have an api like

protocol.registerCustomSchemes({
  'scheme1': 'filesystem, standard',
  'scheme2': 'serviceworker'
})

instead of a strict registerStandardSchemes api, thoughts ?

Fixes #6949

@@ -279,6 +280,21 @@ bool AtomBrowserClient::CanCreateWindow(
return false;
}
void AtomBrowserClient::GetAdditionalAllowedSchemesForFileSystem(
std::vector<std::string>* additional_schemes) {
// Parse --standard-schemes=scheme1,scheme2

This comment has been minimized.

@zcbenz

zcbenz Aug 24, 2016

Contributor

You can use GetStandardSchemes which is defined in atom_api_protocol.h.

This comment has been minimized.

@deepak1556

deepak1556 Aug 24, 2016

Member

Fixed, thanks!

deepak1556 and others added some commits Aug 24, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 25, 2016

👍

@zcbenz zcbenz merged commit 764c84f into electron:master Aug 25, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment