New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only change window state when fullscreen is true #6961

Merged
merged 1 commit into from Aug 25, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 24, 2016

Previously calling setFullScreen(false) on an invisible window on Linux would show it and move it to fullscreen mode.

Closes #6954

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 25, 2016

👍

@zcbenz zcbenz merged commit 6e75e8e into master Aug 25, 2016

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-osx-x64 Build #2271 in progress...
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3944794 succeeded in 55s
Details
electron-linux-ia32 Build #3944795 succeeded in 49s
Details
electron-linux-x64 Build #3944796 succeeded in 85s
Details
electron-win-ia32 Build #1286 succeeded in 7 min 26 sec
Details
electron-win-x64 Build #1270 succeeded in 7 min 23 sec
Details

@zcbenz zcbenz deleted the fullscreen-linux branch Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment