Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize ArrayBuffers as Buffers instead of Arrays over remote #6963

Merged
merged 6 commits into from Aug 25, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Aug 24, 2016

This pull request switches to using Buffer.from instead of Array.slice when generating remote metadata to be sent over IPC.

This reduces the time taken to send a 10mb PDF Buffer as an argument to a remote function from ~10 seconds to ~100ms. This makes it equivalent in time to calling ipcRenderer.sendSync and sending the Buffer as an argument to that API.

Closes #6942

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Aug 24, 2016

kevinsawicki added some commits Aug 24, 2016

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Aug 25, 2016

👍

@zcbenz zcbenz merged commit 97a004a into master Aug 25, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3947112 succeeded in 49s
Details
electron-linux-ia32 Build #3947113 succeeded in 45s
Details
electron-linux-x64 Build #3947114 succeeded in 80s
Details
electron-mas-x64 Build #2268 succeeded in 6 min 48 sec
Details
electron-osx-x64 Build #2274 succeeded in 7 min 38 sec
Details
electron-win-ia32 Build #1294 succeeded in 6 min 23 sec
Details
electron-win-x64 Build #1279 succeeded in 6 min 25 sec
Details

@zcbenz zcbenz deleted the remote-buffers branch Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.