New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cycle detection in IPC arguments #6977

Merged
merged 2 commits into from Aug 26, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 25, 2016

Port over the https://bugs.chromium.org/p/chromium/issues/detail?id=606955 fix from Chromium to Electron's V8ValueConverter to improve cycle detection in arguments passed over IPC calls.

This allows duplicate references in arrays and objects that aren't true cycles to be sent successfully over IPC that were previous null-ed out.

Chromium fix: https://chromium.googlesource.com/chromium/src/+/275ec3e2a5ce1d16fc9c2a0dab3b58f8a7b9fa38

Closes #3598

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 26, 2016

👍

@zcbenz zcbenz merged commit d35613b into master Aug 26, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3952414 succeeded in 52s
Details
electron-linux-ia32 Build #3952415 succeeded in 48s
Details
electron-linux-x64 Build #3952416 succeeded in 83s
Details
electron-mas-x64 Build #2272 succeeded in 6 min 49 sec
Details
electron-osx-x64 Build #2278 succeeded in 6 min 18 sec
Details
electron-win-ia32 Build #1299 succeeded in 6 min 33 sec
Details
electron-win-x64 Build #1283 succeeded in 7 min 12 sec
Details

@zcbenz zcbenz deleted the ipc-cycle-detection branch Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment