Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DownloadItem save path before prompting #6983

Merged
merged 3 commits into from Aug 26, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Aug 25, 2016

For failing URLs (such as 404s), it looks like AtomDownloadManagerDelegate::DetermineDownloadTarget is called before the will-download event fires so the wrapped api::DownloadItem class has not been created yet and so AtomDownloadManagerDelegate::OnDownloadPathGenerated is called to prompt for the path even when it was explicitly set on the download item.

This pull requests adds a check to AtomDownloadManagerDelegate::OnDownloadPathGenerated to see if the specified item has a save path and only prompt when that path is empty.

Closes #6784

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Aug 26, 2016

👍

@zcbenz zcbenz merged commit cd469b5 into master Aug 26, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3957602 succeeded in 52s
Details
electron-linux-ia32 Build #3957603 succeeded in 47s
Details
electron-linux-x64 Build #3957604 succeeded in 83s
Details
electron-mas-x64 Build #2279 succeeded in 7 min 25 sec
Details
electron-osx-x64 Build #2285 succeeded in 7 min 30 sec
Details
electron-win-ia32 Build #1306 succeeded in 6 min 34 sec
Details
electron-win-x64 Build #1289 succeeded in 6 min 26 sec
Details

@zcbenz zcbenz deleted the download-item-prompt branch Aug 26, 2016

@Joshua-Smith

This comment has been minimized.

Copy link

Joshua-Smith commented Aug 26, 2016

Sweet! I'm still new here, so I have a stupid question: How long until this makes it into a version of electron-prebuilt that I can use from electron-builder?

@kevinsawicki

This comment has been minimized.

Copy link
Contributor Author

kevinsawicki commented Aug 26, 2016

How long until this makes it into a version of electron-prebuilt that I can use from electron-builder?

Electron is released every week or so, it will be included in the next patch release which will be 1.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.