New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v7l to ARM release assets #6986

Merged
merged 3 commits into from Aug 31, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 26, 2016

This pull requests adds the v7l suffix to ARM build release assets so they can eventually be disambiguated from future armv6l and arm64 assets that may be produced.

This mirrors the ARM build names that node uses: https://nodejs.org/dist/v4.5.0/

Example

  • Old name: electron-v1.3.4-linux-arm.zip
  • New name: electron-v1.3.4-linux-armv7l.zip

This will be backported to all 1.0+ releases but no old assets will be deleted.

Closes #2343
Refs #5706

@malept

This comment has been minimized.

Member

malept commented Aug 26, 2016

🙌 this is great! I eagerly await the backport so we can finally add ARM support to Electron Packager properly!

@malept malept referenced this pull request Aug 29, 2016

Merged

Add Linux ARMv7 support #474

2 of 2 tasks complete
@malept

This comment has been minimized.

Member

malept commented Aug 31, 2016

Out of curiosity, what is the timeline for this PR? (Or perhaps, what is currently blocking it?) I only ask because I'd like to get this in the next major release (version 8) of Electron Packager and this is basically the last major feature. (I am OK with it slipping to version 9, but having an idea of when it's going to happen would be ideal.)

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 31, 2016

We will include it in the next release which will be published in this week.

@zcbenz zcbenz merged commit 5c051c9 into master Aug 31, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3960712 succeeded in 48s
Details
electron-linux-ia32 Build #3960713 succeeded in 45s
Details
electron-linux-x64 Build #3960714 succeeded in 80s
Details
electron-mas-x64 Build #2283 succeeded in 6 min 34 sec
Details
electron-osx-x64 Build #2291 succeeded in 7 min 13 sec
Details
electron-win-ia32 Build #1312 succeeded in 6 min 31 sec
Details
electron-win-x64 Build #1293 succeeded in 6 min 21 sec
Details

@zcbenz zcbenz deleted the arm-release-asset-name branch Aug 31, 2016

@malept

This comment has been minimized.

Member

malept commented Sep 2, 2016

@zcbenz I see that Electron 1.3.5 has been released, thanks! Is there a timeframe for the backport mentioned in the PR summary?

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Sep 2, 2016

Is there a timeframe for the backport mentioned in the PR summary?

Planning on doing it today, will post back here with updates 📝

@malept

This comment has been minimized.

Member

malept commented Sep 2, 2016

This is probably in your checklist, but please make sure to update the SHASUMS256.txt files for Electron versions 1.3.2 through 1.3.4 as well.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Sep 2, 2016

This is probably in your checklist, but please make sure to update the SHASUMS256.txt files for Electron versions 1.3.2 through 1.3.4 as well.

electron-vX.X.X-linux-armv7l.zip assets now exist for every release back to 1.0.0 and the existing SHASUMS256.txt asset files have been updated.

I did not backport the rename to the other assets such as chromedriver, mksnapshot, or ffmpeg since they are downloaded significantly less than the main Electron release asset and tooling like electron-packager does not integrate with them directly.

@malept

This comment has been minimized.

Member

malept commented Sep 2, 2016

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment