Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese font rendering in flash. #7018

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
3 participants
@HanaeKae
Copy link
Contributor

HanaeKae commented Aug 29, 2016

This problem has been resolved.
#5704 (comment)

From this source, it was to merge the case of Windows.
https://chromium.googlesource.com/chromium/src.git/+/master/chrome/renderer/pepper/pepper_flash_font_file_host.cc#71

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Aug 30, 2016

It looks like the build is failing on AppVeyor:

not ok 310 tag loads devtools extensions registered on the parent window
TypeError: Cannot read property 'webContents' of null
at C:\projects\electron\spec\api-browser-window-spec.js:1155:42
at CallbacksRegistry.apply (C:\projects\electron\out\D\resources\electron.asar\common\api\callbacks-registry.js:54:39)
at EventEmitter. (C:\projects\electron\out\D\resources\electron.asar\renderer\api\remote.js:241:21)
at emitThree (events.js:116:13)
at EventEmitter.emit (events.js:194:7

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Aug 30, 2016

👍 Thanks!

@zeke Those tests are a bit flaky, rerunning the build makes them gone.

@zcbenz zcbenz merged commit 572f58b into electron:master Aug 30, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.