New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for titleBarStyle: 'hidden-inset' on OS X 10.9 #7077

Merged
merged 1 commit into from Sep 9, 2016

Conversation

Projects
None yet
3 participants
@miniak
Contributor

miniak commented Sep 2, 2016

Follow up to: #6848

@miniak

This comment has been minimized.

Contributor

miniak commented Sep 2, 2016

screen shot 2016-09-03 at 1 29 44 am

@miniak

This comment has been minimized.

Contributor

miniak commented Sep 6, 2016

@sindresorhus why thumbs down?

@sindresorhus

This comment has been minimized.

Contributor

sindresorhus commented Sep 6, 2016

I just don't think it's worth the complexity cost for something so non-essential. Most don't even support 10.9 anymore.

@miniak

This comment has been minimized.

Contributor

miniak commented Sep 6, 2016

@sindresorhus That's your opinion. The code is not that complex. I think it's worth it, it makes the behavior consistent between all versions of macOS. In the future when support for OS X 10.9 gets dropped, all that code can be removed.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 9, 2016

I don't care about OS X 10.9, but I agree the code does not add much compatibility and I think it is not a bad thing to have. 👍

@zcbenz zcbenz merged commit 7ed33df into electron:master Sep 9, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miniak miniak deleted the miniak:title-bar-style branch Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment