New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore process.noAsar in finally block #7116

Merged
merged 2 commits into from Sep 7, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Sep 6, 2016

Previously is execSync threw an error the value of process.noAsar would be left as true instead of reset to its original value.

Closes #7011

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 7, 2016

👍

@zcbenz zcbenz merged commit e561608 into master Sep 7, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4047317 succeeded in 51s
Details
electron-linux-ia32 Build #4047318 succeeded in 46s
Details
electron-linux-x64 Build #4047319 succeeded in 82s
Details
electron-mas-x64 Build #2302 succeeded in 6 min 21 sec
Details
electron-osx-x64 Build #2310 succeeded in 7 min 9 sec
Details
electron-win-ia32 Build #1364 succeeded in 6 min 26 sec
Details
electron-win-x64 Build #1342 succeeded in 6 min 21 sec
Details

@zcbenz zcbenz deleted the restore-no-asar branch Sep 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment