New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOF process.stdin in render process #7130

Merged
merged 3 commits into from Sep 8, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Sep 7, 2016

This pull requests moves the process.stdin patching from the browser/init.js to common/init.js so it happens in both the browser and renderer processes on Windows.

This prevents errors accessing and reading from it from the renderer processes.

Previously it would throw a Implement me. Unknown stdin file type! when accessed.

Closes #7088

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 8, 2016

👍

@zcbenz zcbenz merged commit a0eccdf into master Sep 8, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4061743 succeeded in 49s
Details
electron-linux-ia32 Build #4061744 succeeded in 49s
Details
electron-linux-x64 Build #4061745 succeeded in 81s
Details
electron-mas-x64 Build #2313 succeeded in 7 min 20 sec
Details
electron-osx-x64 Build #2321 succeeded in 7 min 27 sec
Details
electron-win-ia32 Build #1376 succeeded in 6 min 30 sec
Details
electron-win-x64 Build #1354 succeeded in 6 min 17 sec
Details

@zcbenz zcbenz deleted the windows-stdin-renderer branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment