Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End sheet in parent when closing modal window #7131

Merged
merged 1 commit into from Sep 8, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Sep 7, 2016

Call endSheet on parent when explicitly closing modal window so that other sheets (like message boxes) can be shown on the parent in the future.

Closes #6293

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Sep 8, 2016

👍

@zcbenz zcbenz merged commit 2885e98 into master Sep 8, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4062446 succeeded in 52s
Details
electron-linux-ia32 Build #4062447 succeeded in 48s
Details
electron-linux-x64 Build #4062448 succeeded in 83s
Details
electron-mas-x64 Build #2314 succeeded in 7 min 0 sec
Details
electron-osx-x64 Build #2322 succeeded in 7 min 36 sec
Details
electron-win-ia32 Build #1377 succeeded in 6 min 0 sec
Details
electron-win-x64 Build #1355 succeeded in 6 min 16 sec
Details

@zcbenz zcbenz deleted the end-sheet-on-close branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.