New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return booleans from more shell APIs #7182

Merged
merged 4 commits into from Sep 13, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Sep 12, 2016

This pull request switches shell.showItemInFolder and shell.openItem to return a Boolean instead of undefined indicating the success of the call. This makes these two APIs consistent with shell.openExternal that already returns a Boolean.

Refs #7176

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 13, 2016

👍

@zcbenz zcbenz merged commit b13bab6 into master Sep 13, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4107030 succeeded in 49s
Details
electron-linux-ia32 Build #4107031 succeeded in 46s
Details
electron-linux-x64 Build #4107032 succeeded in 96s
Details
electron-mas-x64 Build #2358 succeeded in 7 min 24 sec
Details
electron-osx-x64 Build #2366 succeeded in 8 min 2 sec
Details
electron-win-ia32 Build #1434 succeeded in 6 min 44 sec
Details
electron-win-x64 Build #1410 succeeded in 6 min 47 sec
Details

@zcbenz zcbenz deleted the shell-return-values branch Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment