New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against missing remote function properties #7209

Merged
merged 4 commits into from Sep 16, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Sep 14, 2016

A remote function that is no longer available when its properties are accessed will throws error when the member metadata is lazily loaded.

This pull request guards against this case and at least partially fixes #7196, specifically the Cannot read property 'Symbol(Symbol.iterator)' of undefined errors.

}
return new Proxy(remoteMemberFunction, {
set: function(target, property, value, receiver) {
if (property !== 'ref') loadRemoteProperties()

This comment has been minimized.

@kevinsawicki

kevinsawicki Sep 14, 2016

Contributor

This prevents eagerly loading the function properties when the function is accessed or invoked.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 16, 2016

👍

@zcbenz zcbenz merged commit ea244a5 into master Sep 16, 2016

4 of 9 checks passed

electron-mas-x64 Build #2379 failed in 7 min 20 sec
Details
electron-osx-x64 Build #2384 failed in 7 min 4 sec
Details
electron-win-x64 Build #1429 failed in 6 min 42 sec
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
electron-linux-x64 Build #4133531 failed in 100s
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4133529 succeeded in 52s
Details
electron-linux-ia32 Build #4133530 succeeded in 48s
Details
electron-win-ia32 Build #1452 succeeded in 6 min 48 sec
Details

@zcbenz zcbenz deleted the remote-function-missing-properties branch Sep 16, 2016

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Sep 20, 2016

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment