New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ctrl+Y as the accelerator of redo on Windows #7236

Merged
merged 1 commit into from Sep 19, 2016

Conversation

Projects
None yet
4 participants
@yuya-oc
Contributor

yuya-oc commented Sep 17, 2016

For redo role, Ctrl+Y is more consistent with other Windows applications.

@@ -69,7 +69,7 @@ const roles = {
},
redo: {
label: 'Redo',
accelerator: 'Shift+CommandOrControl+Z',
accelerator: process.platform === 'win32' ? 'CommandOrControl+Y' : 'Shift+CommandOrControl+Z',

This comment has been minimized.

@sindresorhus

sindresorhus Sep 17, 2016

Contributor

This would be more explicit and shorter:

accelerator: process.platform === 'win32' ? 'Control+Y' : 'Shift+CommandOrControl+Z',

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Sep 17, 2016

Member

Purely because I enjoy playing code golf

accelerator: `CommandOrControl+${process.platform === 'win32' ? 'Y' : 'Shift+Z'}`

Note: Don't use this ^^, it isn't very clear what it does 👍 But it is shorter 😆

This comment has been minimized.

@yuya-oc

yuya-oc Sep 18, 2016

Contributor

Thanks. I will use Control+Y.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 19, 2016

👍

@zcbenz zcbenz merged commit 0ac4b89 into electron:master Sep 19, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

yhatt added a commit to yhatt/marp that referenced this pull request Oct 2, 2016

@yhatt yhatt referenced this pull request Oct 2, 2016

Merged

Update Electron to 1.4.1 #91

@yuya-oc yuya-oc deleted the yuya-oc:accelerator-for-redo branch Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment