Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for missing additional features fields when creating new popup windows #7291
The non-standard features (like this-is-not-a-standard-feature) given to window.open() are lost in the popup window creation workflow. This leads to the 'new-window' event handler not receiving these 'additional' features. These features may be used by applications to give some specific data to the popup.
NOTE : This pull request depends on pull request #234 in libchromiumcontent repo.
referenced this pull request
Sep 21, 2016
@MichaelVasseur can you add a note to https://github.com/electron/electron/blob/master/docs/api/window-open.md explaining the change you've made here?