The non-standard features (like this-is-not-a-standard-feature) given to window.open() are lost in the popup window creation workflow. This leads to the 'new-window' event handler not receiving these 'additional' features. These features may be used by applications to give some specific data to the popup.
NOTE : This pull request depends on pull request #234 in libchromiumcontent repo.
@MichaelVasseur can you add a note to https://github.com/electron/electron/blob/master/docs/api/window-open.md explaining the change you've made here?
@zeke I pushed the changes to the documentation. Thanks for your feedback !
This indenting seems off by quite a bit, it should be aligned with the line above
Indenting again, maybe your editor is configured from tabs / spaces incorrectly?
@MarshallOfSound Indentation issues fixed.
Remaining errors are due to C++ interfaces changes required (introduced in #234)
Update libchromiumcontent for #7291
Updated required code to handle missing additional features for popup…
Documented JavasScript API changes related to the fix for additional …
Format the docs according to style guide
I added a new PR #7494 to unit test this change.