New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing additional features fields when creating new popup windows #7291

Merged
merged 4 commits into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@MichaelVasseur

MichaelVasseur commented Sep 21, 2016

The non-standard features (like this-is-not-a-standard-feature) given to window.open() are lost in the popup window creation workflow. This leads to the 'new-window' event handler not receiving these 'additional' features. These features may be used by applications to give some specific data to the popup.

NOTE : This pull request depends on pull request #234 in libchromiumcontent repo.

@zeke

This comment has been minimized.

Member

zeke commented Sep 22, 2016

@MichaelVasseur can you add a note to https://github.com/electron/electron/blob/master/docs/api/window-open.md explaining the change you've made here?

@MichaelVasseur

This comment has been minimized.

MichaelVasseur commented Sep 23, 2016

@zeke I pushed the changes to the documentation. Thanks for your feedback !

@@ -525,6 +525,7 @@ void App::OnLogin(LoginHandler* login_handler,
void App::OnCreateWindow(const GURL& target_url,
const std::string& frame_name,
WindowOpenDisposition disposition,
const std::vector<base::string16>& features,

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Sep 23, 2016

Member

This indenting seems off by quite a bit, it should be aligned with the line above

@@ -50,6 +50,7 @@ class App : public AtomBrowserClient::Delegate,
void OnCreateWindow(const GURL& target_url,
const std::string& frame_name,
WindowOpenDisposition disposition,
const std::vector<base::string16>& features,

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Sep 23, 2016

Member

Indenting again, maybe your editor is configured from tabs / spaces incorrectly?

@MichaelVasseur

This comment has been minimized.

MichaelVasseur commented Sep 23, 2016

@MarshallOfSound Indentation issues fixed.

@MichaelVasseur

This comment has been minimized.

MichaelVasseur commented Sep 23, 2016

Remaining errors are due to C++ interfaces changes required (introduced in #234)

@zcbenz zcbenz self-assigned this Oct 4, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Oct 4, 2016

👍

@zcbenz zcbenz merged commit bf21892 into electron:master Oct 4, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@MichaelVasseur

This comment has been minimized.

MichaelVasseur commented Oct 5, 2016

I added a new PR #7494 to unit test this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment