Workaround for electron/electron#5050 #7319

Merged
merged 3 commits into from Sep 29, 2016

Projects

None yet

3 participants

@Menci
Contributor
Menci commented Sep 23, 2016

Workaround for electron/electron#5050

Chromium only show the Tray icon with libappindicator when the env XDG_CURRENT_DESKTOP's value is Unity. But under elementaryOS its value is 'Pantheon'.

Set it to Unity before app startup make the tray icon show under elementaryOS.

@Menci Menci 🐧 🐛 Workaround for electron/electron#5050
Chromium only show the Tray icon with libappindicator when the env `XDG_CURRENT_DESKTOP`'s value is `Unity`. But under elementaryOS its value is 'Pantheon'.

Set it to `Unity` before app startup make the tray icon show under elementaryOS.
938b9e8
@Menci Menci changed the title from :penguin: :bug: Workaround for electron/electron#5050 to Workaround for electron/electron#5050 Sep 23, 2016
@zcbenz
Contributor
zcbenz commented Sep 27, 2016

Can you move this to lib/browser/init.js? Only using it in the main process should be enough.

@Menci Menci 🐧 🐛 Move the workaround to `lib/browser/init.js`
ef45b67
@Menci
Contributor
Menci commented Sep 27, 2016

OK. I hope it's not the wrong place to put it just before entering app's main.

@zeke
Member
zeke commented Sep 27, 2016

@Menci you've got a linting error:

/home/travis/build/electron/electron/lib/browser/init.js:167:44: Extra semicolon.

@Menci Menci 🎨 Remove extra semicolon
ca68dfe
@zcbenz
Contributor
zcbenz commented Sep 29, 2016

👍

@zcbenz zcbenz merged commit 734f42b into electron:master Sep 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment