New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for electron/electron#5050 #7319

Merged
merged 3 commits into from Sep 29, 2016

Conversation

Projects
None yet
3 participants
@Menci
Contributor

Menci commented Sep 23, 2016

Workaround for #5050

Chromium only show the Tray icon with libappindicator when the env XDG_CURRENT_DESKTOP's value is Unity. But under elementaryOS its value is 'Pantheon'.

Set it to Unity before app startup make the tray icon show under elementaryOS.

🐧 🐛 Workaround for #5050
Chromium only show the Tray icon with libappindicator when the env `XDG_CURRENT_DESKTOP`'s value is `Unity`. But under elementaryOS its value is 'Pantheon'.

Set it to `Unity` before app startup make the tray icon show under elementaryOS.

@Menci Menci changed the title from :penguin: :bug: Workaround for electron/electron#5050 to Workaround for electron/electron#5050 Sep 23, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 27, 2016

Can you move this to lib/browser/init.js? Only using it in the main process should be enough.

@Menci

This comment has been minimized.

Contributor

Menci commented Sep 27, 2016

OK. I hope it's not the wrong place to put it just before entering app's main.

@zeke

This comment has been minimized.

Member

zeke commented Sep 27, 2016

@Menci you've got a linting error:

/home/travis/build/electron/electron/lib/browser/init.js:167:44: Extra semicolon.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 29, 2016

👍

@zcbenz zcbenz merged commit 734f42b into electron:master Sep 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment