Add cookie changed event #7398

Merged
merged 8 commits into from Sep 30, 2016

Projects

None yet

2 participants

@kevinsawicki
Contributor
kevinsawicki commented Sep 29, 2016 edited

This pull requests add a 'changed' event to the Cookies class that will fire when a cookie is added, edited, removed, or evicted.

/cc @brian-mann is this along the lines of what you are looking to get access to?

Closes #5643

@kevinsawicki kevinsawicki referenced this pull request in electron/brightray Sep 29, 2016
Merged

Support configuring a cookie delegate #251

@kevinsawicki kevinsawicki changed the title from [WIP] Add cookie changed event to Add cookie changed event Sep 29, 2016
@zcbenz
Contributor
zcbenz commented Sep 29, 2016

👍

kevinsawicki added some commits Sep 21, 2016
@kevinsawicki kevinsawicki Upgrade brigthray for cookie monster delegate 5d23d16
@kevinsawicki kevinsawicki Add initial cookie changed event support 24bcf6a
@kevinsawicki kevinsawicki Use scoped_refptr for cookie delegate 19c7ee0
@kevinsawicki kevinsawicki Add specs for cookie changed event d83534d
@kevinsawicki kevinsawicki Document cookie changed event 96e48ac
@kevinsawicki kevinsawicki Use separate session for cookies change event test 77b35ba
@kevinsawicki kevinsawicki Remove unneeded locker and handle scope
8abe8fe
@kevinsawicki kevinsawicki Upgrade brightray for merged cookie delegate support
0e1290f
@zcbenz zcbenz merged commit 1b5db42 into master Sep 30, 2016

7 of 9 checks passed

electron-win-ia32 Build #1572 failed in 8 min 16 sec
Details
electron-win-x64 Build #1547 failed in 8 min 23 sec
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4282109 succeeded in 71s
Details
electron-linux-ia32 Build #4282110 succeeded in 60s
Details
electron-linux-x64 Build #4282111 succeeded in 116s
Details
electron-mas-x64 Build #2477 succeeded in 8 min 59 sec
Details
electron-osx-x64 Build #2485 succeeded in 9 min 2 sec
Details
@zcbenz zcbenz deleted the cookie-changed-event branch Sep 30, 2016
@aluxian-huginn aluxian-huginn referenced this pull request in Aluxian/Messenger-for-Desktop Sep 30, 2016
Closed

Update dependency: electron v1.4.2 #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment