New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Show Tab Bar menu item on macOS Sierra #7415

Merged
merged 2 commits into from Sep 30, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Sep 29, 2016

This pull request ports the fix for https://bugs.chromium.org/p/chromium/issues/detail?id=642155 into Electron to remove the "Show Tab Bar" on macOS Sierra.

Closes #7406
Refs #6124

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 30, 2016

👍

@zcbenz zcbenz merged commit 11d16a7 into master Sep 30, 2016

7 of 9 checks passed

electron-win-ia32 Build #1576 failed in 8 min 3 sec
Details
electron-win-x64 Build #1551 failed in 8 min 7 sec
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4283339 succeeded in 66s
Details
electron-linux-ia32 Build #4283340 succeeded in 54s
Details
electron-linux-x64 Build #4283341 succeeded in 111s
Details
electron-mas-x64 Build #2481 succeeded in 8 min 46 sec
Details
electron-osx-x64 Build #2489 succeeded in 9 min 23 sec
Details

@zcbenz zcbenz deleted the disable-tab-menu-on-sierra branch Sep 30, 2016

@yuya-oc yuya-oc referenced this pull request Oct 6, 2016

Closed

There is unexpected "Show Tab Bar" menu item on macOS 10.12 #337

4 of 4 tasks complete

dcondrey referenced this pull request in dcondrey/N1 Oct 9, 2016

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Feb 8, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment