New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore already closed windows #7432

merged 1 commit into from Oct 3, 2016


None yet
2 participants

kevinsawicki commented Sep 30, 2016

When an embedder's render view is deleted, the guest is destroyed,

embedder.once('render-view-deleted', closedByEmbedder)
guest.once('closed', closedByUser)

This is causing issues on Windows when WindowList::CloseAllWindows() is called since when the first window is closed, the second window will also be closed causing a crash when NativeWindow::Close() is called a second time and a crash occurs when checking the accelerated widget in IsClosable().

This pull request adds a check for IsClosed() before calling Close() to guard against this.

Not sure if this check is better to put in NativeWindowViews::Close()instead.

Closes #7074


This comment has been minimized.


zcbenz commented Oct 3, 2016


@zcbenz zcbenz merged commit ec34bfd into master Oct 3, 2016

7 of 8 checks passed

electron-win-ia32 Build #1592 failed in 8 min 1 sec
continuous-integration/travis-ci/pr The Travis CI build passed
electron-linux-arm Build #4300169 succeeded in 60s
electron-linux-ia32 Build #4300170 succeeded in 53s
electron-linux-x64 Build #4300171 succeeded in 109s
electron-mas-x64 Build #2498 succeeded in 8 min 6 sec
electron-osx-x64 Build #2504 succeeded in 9 min 20 sec
electron-win-x64 Build #1568 succeeded in 8 min 3 sec

@zcbenz zcbenz deleted the check-if-window-closed branch Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment