New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ELECTRON_NO_ASAR #7479

Merged
merged 4 commits into from Oct 12, 2016

Conversation

Projects
None yet
2 participants
@bpasero
Contributor

bpasero commented Oct 4, 2016

For #6295

This new environment variable can be used to disable ASAR support in forked processes. The use case is:

var res = cp.fork(path.join(__dirname, "forked.js"), { env: { "ELECTRON_NO_ASAR": "true" }});

This disables ASAR support in forked processes and does not force the forked process to set process.noAsar. This specifically enables to run a forked process in an environment that comes close to the real node.js environment without forcing it to use the non-node.js process.noAsar trick.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Oct 7, 2016

Contributor

@bpasero I added a few specs and also added a check to only disable asar when ELECTRON_NO_ASAR is set and the process.type isn't browser nor renderer. This is so running ELECTRON_NO_ASAR=1 electron.exe does not cause Electron to fail to launch.

Please confirm these changes look good to you and I'll merge this in.

Contributor

kevinsawicki commented Oct 7, 2016

@bpasero I added a few specs and also added a check to only disable asar when ELECTRON_NO_ASAR is set and the process.type isn't browser nor renderer. This is so running ELECTRON_NO_ASAR=1 electron.exe does not cause Electron to fail to launch.

Please confirm these changes look good to you and I'll merge this in.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Oct 12, 2016

Contributor

Please confirm these changes look good to you and I'll merge this in.

Going to merge this in, thanks for adding it 👍

Contributor

kevinsawicki commented Oct 12, 2016

Please confirm these changes look good to you and I'll merge this in.

Going to merge this in, thanks for adding it 👍

@kevinsawicki kevinsawicki merged commit fefc7c2 into electron:master Oct 12, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@bpasero bpasero deleted the bpasero:process-no-asar branch Oct 13, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 13, 2016

Contributor

@kevinsawicki thanks for the additional changes and merging it in 👍

Contributor

bpasero commented Oct 13, 2016

@kevinsawicki thanks for the additional changes and merging it in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment