New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store crash reports in configured temp dir #7500

Merged
merged 23 commits into from Oct 10, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Oct 5, 2016

This pull request updates the crash reporter to store reports in the app.getPath('temp') directory instead of /tmp on Linux/Mac and the default temp dir on Windows.

This enables portable Electron apps to ensure crash report details are stored in the location they configure.

  • Update specs
  • Update CrashReporter to an ES6 class and clean up CoffeeScript leftovers
  • Update docs
  • Manually test on macOS
  • Manually test on Linux
  • Manually test on Windows

Closes #7399

@kevinsawicki kevinsawicki changed the title from Store crash reports in configured temp dir to [WIP] Store crash reports in configured temp dir Oct 5, 2016

@kevinsawicki kevinsawicki changed the title from [WIP] Store crash reports in configured temp dir to Store crash reports in configured temp dir Oct 6, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Oct 10, 2016

👍

@zcbenz zcbenz merged commit 91591f3 into master Oct 10, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4351451 succeeded in 61s
Details
electron-linux-ia32 Build #4351452 succeeded in 53s
Details
electron-linux-x64 Build #4351453 succeeded in 109s
Details
electron-mas-x64 Build #2554 succeeded in 9 min 2 sec
Details
electron-osx-x64 Build #2561 succeeded in 9 min 21 sec
Details
electron-win-ia32 Build #1648 succeeded in 7 min 47 sec
Details
electron-win-x64 Build #1623 succeeded in 8 min 5 sec
Details

@zcbenz zcbenz deleted the store-crashes-in-configured-temp-dir branch Oct 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment