New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default webPreferences to empty object always #7520

Merged
merged 2 commits into from Oct 7, 2016

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Member

MarshallOfSound commented Oct 7, 2016

Fixes #7519

@twolfson

This comment has been minimized.

Contributor

twolfson commented Oct 7, 2016

Would it be possible to add a smoke test like running window.open somewhere?

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Oct 7, 2016

@twolfson Yeah, I was just looking into why the tests managed to pass. Added another test that has webPreferences as undefined 👍

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Oct 7, 2016

@MarshallOfSound Thanks for fixing this 👍 👍 👍

@kevinsawicki kevinsawicki merged commit 9339853 into master Oct 7, 2016

6 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #2562 succeeded in 7 min 57 sec
Details
electron-osx-x64 Build #2569 succeeded in 9 min 13 sec
Details
electron-win-ia32 Build #1656 succeeded in 8 min 0 sec
Details
electron-win-x64 Build #1631 succeeded in 8 min 1 sec
Details

@kevinsawicki kevinsawicki deleted the fix-undef-webprefs branch Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment