Default webPreferences to empty object always #7520

Merged
merged 2 commits into from Oct 7, 2016

Projects

None yet

3 participants

@MarshallOfSound
Member

Fixes #7519

@MarshallOfSound MarshallOfSound Default webPreferences to empty object always
09e5035
@twolfson
Contributor
twolfson commented Oct 7, 2016

Would it be possible to add a smoke test like running window.open somewhere?

@MarshallOfSound MarshallOfSound Add spec for window.open with webPreferences set to null
a0284a9
@MarshallOfSound
Member

@twolfson Yeah, I was just looking into why the tests managed to pass. Added another test that has webPreferences as undefined 👍

@kevinsawicki
Contributor

@MarshallOfSound Thanks for fixing this 👍 👍 👍

@kevinsawicki kevinsawicki merged commit 9339853 into master Oct 7, 2016

6 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #2562 succeeded in 7 min 57 sec
Details
electron-osx-x64 Build #2569 succeeded in 9 min 13 sec
Details
electron-win-ia32 Build #1656 succeeded in 8 min 0 sec
Details
electron-win-x64 Build #1631 succeeded in 8 min 1 sec
Details
@kevinsawicki kevinsawicki deleted the fix-undef-webprefs branch Oct 7, 2016
@aluxian-huginn aluxian-huginn referenced this pull request in Aluxian/Messenger-for-Desktop Oct 20, 2016
Closed

Update dependency: electron v1.4.4 #885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment