New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting about panel options #7549

Merged
merged 2 commits into from Oct 11, 2016

Conversation

Projects
None yet
4 participants
@kevinsawicki
Contributor

kevinsawicki commented Oct 10, 2016

Allow the application name, version, copyright, and credits shown in the about panel on macOS to be configurable at runtime.

See https://developer.apple.com/reference/appkit/nsapplication/1428479-orderfrontstandardaboutpanelwith?language=objc for more details.

Fixes #6955

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Oct 11, 2016

👍

@zcbenz zcbenz merged commit 4ae190d into master Oct 11, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4381698 succeeded in 104s
Details
electron-linux-ia32 Build #4381699 succeeded in 97s
Details
electron-linux-x64 Build #4381700 succeeded in 153s
Details
electron-mas-x64 Build #2584 succeeded in 7 min 47 sec
Details
electron-osx-x64 Build #2589 succeeded in 9 min 16 sec
Details
electron-win-ia32 Build #1678 succeeded in 7 min 59 sec
Details
electron-win-x64 Build #1653 succeeded in 8 min 3 sec
Details

@zcbenz zcbenz deleted the about-panel-options branch Oct 11, 2016

@Mercieral

This comment has been minimized.

Mercieral commented Oct 11, 2016

Awesome thanks!

@enlight

This comment has been minimized.

Contributor

enlight commented Oct 12, 2016

The capitalization of property names in the options object is inconsistent with the rest of the Electron API, does that bug anyone else, or just me? :)

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Oct 12, 2016

The capitalization of property names in the options object is inconsistent with the rest of the Electron API, does that bug anyone else, or just me? :)

Yeah, I went with matching the macOS key names from the API it calls, I'm fine switching it to be camel-cased though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment