New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: fix race in creation of default browser context by AtomAccessTokenStore #7628

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
3 participants
@deepak1556
Member

deepak1556 commented Oct 14, 2016

When no default browser context is created, multiple calls to TokenLoadingJob will cause a race in browser context creation and crash. The patch creates the browser context when access token store is initialized and passes it to TokenLoadingJob.

Fixes #7607

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Oct 24, 2016

Contributor

👍

Contributor

zcbenz commented Oct 24, 2016

👍

@zcbenz zcbenz merged commit 88ac376 into electron:master Oct 24, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kazkondo

This comment has been minimized.

Show comment
Hide comment
@kazkondo

kazkondo Jan 18, 2017

This change causes a few seconds freezing of the UI thread when loading a site such as http://www.google.com in webview tag. If you quit the application during that freeze, electrons crash.

kazkondo commented Jan 18, 2017

This change causes a few seconds freezing of the UI thread when loading a site such as http://www.google.com in webview tag. If you quit the application during that freeze, electrons crash.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 4, 2017

@kazkondo I've got the same problem. Is there any possibility to fix this?

ghost commented Apr 4, 2017

@kazkondo I've got the same problem. Is there any possibility to fix this?

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Apr 4, 2017

Member

@simoncaminada the freezing thread issue has been fixed in #8923 and is available with 1.6.5-beta release.

Member

deepak1556 commented Apr 4, 2017

@simoncaminada the freezing thread issue has been fixed in #8923 and is available with 1.6.5-beta release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment