New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification crash when using permission handler #7788

Merged
merged 5 commits into from Oct 31, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Oct 28, 2016

This pull request upgrades Brightray to include electron-archive/brightray#258 and also adds a spec for using setPermissionRequestHandler with notifications.

Also updates a few asserts that were using assert instead of assert.equal/assert.deepEqual.

/cc @deepak1556 馃憖

Fixes #7645

@kevinsawicki kevinsawicki changed the title from Fix notification crash when using permission handler to [WIP] Fix notification crash when using permission handler Oct 28, 2016

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Oct 28, 2016

Member

looks good to me 馃憤

Member

deepak1556 commented Oct 28, 2016

looks good to me 馃憤

@kevinsawicki kevinsawicki changed the title from [WIP] Fix notification crash when using permission handler to Fix notification crash when using permission handler Oct 31, 2016

@kevinsawicki kevinsawicki merged commit aa3bc13 into master Oct 31, 2016

7 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-win-x64 Build #1763 in progress...
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4567383 succeeded in 68s
Details
electron-linux-ia32 Build #4567384 succeeded in 60s
Details
electron-linux-x64 Build #4567385 succeeded in 119s
Details
electron-mas-x64 Build #2710 succeeded in 9 min 3 sec
Details
electron-osx-x64 Build #2725 succeeded in 10 min
Details
electron-win-ia32 Build #1788 succeeded in 8 min 23 sec
Details

@kevinsawicki kevinsawicki deleted the notification-crash branch Oct 31, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Oct 31, 2016

Contributor

Thanks @deepak1556 for fixing this 馃憤

Contributor

kevinsawicki commented Oct 31, 2016

Thanks @deepak1556 for fixing this 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment