New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial scripts to publish electron.d.ts #7857

Merged
merged 4 commits into from May 5, 2017

Conversation

Projects
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Nov 3, 2016

Setting up the scripts that would upload a generated electron.d.ts file when we reach an MVP state on electron-definitelytyped

Show outdated Hide outdated package.json

@MarshallOfSound MarshallOfSound changed the title from [WIP] Initial scripts to publish electron.d.ts to Initial scripts to publish electron.d.ts Nov 8, 2016

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Nov 15, 2016

Member

Ping @zeke

Whats the plan for this / what else needs to be updated in the release pipeline 👍

Member

MarshallOfSound commented Nov 15, 2016

Ping @zeke

Whats the plan for this / what else needs to be updated in the release pipeline 👍

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 15, 2016

Member

@MarshallOfSound this looks good!

The only thing I see missing is a call to the generate-dts script. I suppose it could be invoked from release.py, but the easiest way to tack it on would probably be just adding && npm run generate-dts to the existing lint script. It's not really a linting task, but maybe that's okay...

Member

zeke commented Nov 15, 2016

@MarshallOfSound this looks good!

The only thing I see missing is a call to the generate-dts script. I suppose it could be invoked from release.py, but the easiest way to tack it on would probably be just adding && npm run generate-dts to the existing lint script. It's not really a linting task, but maybe that's okay...

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 16, 2016

Member

Rebased and updated the cibuild script. @zcbenz does that seem like the right place to put it?

Member

zeke commented Nov 16, 2016

Rebased and updated the cibuild script. @zcbenz does that seem like the right place to put it?

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Mar 2, 2017

Member

I just rebased and force-pushed this branch. There are some changes to the linter that will need to land before we can ship this: electron/electron-docs-linter#85

Member

zeke commented Mar 2, 2017

I just rebased and force-pushed this branch. There are some changes to the linter that will need to land before we can ship this: electron/electron-docs-linter#85

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Apr 1, 2017

Member

Okay, we renamed the repo and module to electron-typescript-definitions and just published a first version of it at 1.0.0

@MarshallOfSound using the current incantation of electron-typescript-definitions --in=out/electron-api.json --out=out/electron.d.ts, is there any guarantee that the generated electron.d.ts file is valid? If not, we should figure out a way to incorporate a test into this CLI command, so we can fail and halt the build if the file is invalid.

Member

zeke commented Apr 1, 2017

Okay, we renamed the repo and module to electron-typescript-definitions and just published a first version of it at 1.0.0

@MarshallOfSound using the current incantation of electron-typescript-definitions --in=out/electron-api.json --out=out/electron.d.ts, is there any guarantee that the generated electron.d.ts file is valid? If not, we should figure out a way to incorporate a test into this CLI command, so we can fail and halt the build if the file is invalid.

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Apr 1, 2017

Member

@zeke We could just move all devDeps of electron-typescript-definitions to be prod deps and run the test command after generating the typings 👍

Member

MarshallOfSound commented Apr 1, 2017

@zeke We could just move all devDeps of electron-typescript-definitions to be prod deps and run the test command after generating the typings 👍

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Apr 1, 2017

Member

We could just move all devDeps

Sounds good. I think there are currently also some dependencies that could be moved to devDependencies as well.

Member

zeke commented Apr 1, 2017

We could just move all devDeps

Sounds good. I think there are currently also some dependencies that could be moved to devDependencies as well.

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 3, 2017

Member

Okay so we're now generating and tslinting electron.d.ts as part of the distribution process and Travis and Appveyor are happy.

@kevinsawicki does this setup look right?

@MarshallOfSound are you happy with the current electron.d.ts this is generating?

If so, let's ship this!

Member

zeke commented May 3, 2017

Okay so we're now generating and tslinting electron.d.ts as part of the distribution process and Travis and Appveyor are happy.

@kevinsawicki does this setup look right?

@MarshallOfSound are you happy with the current electron.d.ts this is generating?

If so, let's ship this!

@zeke zeke requested a review from kevinsawicki May 3, 2017

@kevinsawicki

LGTM

@MarshallOfSound

LGTM, there are a few outstanding issues but I don't consider any of them blockers 👍

@zeke zeke merged commit 7d7a2d9 into master May 5, 2017

5 of 9 checks passed

electron-mas-x64 Build #4071 failed in 8 min 44 sec
Details
electron-osx-x64 Build #4073 failed in 12 min
Details
electron-win-x64 Build #3030 failed in 9 min 53 sec
Details
electron-linux-x64 Build #6463718 failed in 197s
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6463716 succeeded in 125s
Details
electron-linux-ia32 Build #6463717 succeeded in 116s
Details
electron-win-ia32 Build #3057 succeeded in 8 min 25 sec
Details

@zeke zeke deleted the publish-electron.d.ts branch May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment