New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dist url to be electron instead of atom-shell #7881

Merged
merged 3 commits into from Nov 4, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Nov 4, 2016

Renames the distribution URL used for downloading the v8 headers from https://atom.io/download/atom-shell to https://atom.io/download/electron.

Both URLs will be supported going forward but the old one may possibly be removed in Electron 2.0.

@zeke zeke referenced this pull request Nov 4, 2016

Merged

update v8 headers URL #878

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke
Member

zeke commented Nov 4, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 4, 2016

Contributor

It looks there are several other instances of the old URL in this repo:

Thanks, updated those as well 👍

Contributor

kevinsawicki commented Nov 4, 2016

It looks there are several other instances of the old URL in this repo:

Thanks, updated those as well 👍

@zeke

zeke approved these changes Nov 4, 2016

🎉

@kevinsawicki kevinsawicki merged commit 0b86acf into master Nov 4, 2016

0 of 6 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #4618923 started
Details
electron-linux-ia32 Build #4618924 queued
Details
electron-linux-x64 Build #4618925 queued
Details
electron-win-x64 Build #1806 in progress...
Details

@kevinsawicki kevinsawicki deleted the node-headers-url branch Nov 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment