New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol: register about scheme handler #7908

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Projects
None yet
3 participants
@deepak1556
Member

deepak1556 commented Nov 9, 2016

Fixes #7883

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 9, 2016

Contributor

@deepak1556 what is the best way to manually see the error from #7883, I tried the following page on master but didn't see that error in the dev tools:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title></title>
  </head>
  <body>
    <iframe src="about:blank">
  </body>
</html>
Contributor

kevinsawicki commented Nov 9, 2016

@deepak1556 what is the best way to manually see the error from #7883, I tried the following page on master but didn't see that error in the dev tools:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title></title>
  </head>
  <body>
    <iframe src="about:blank">
  </body>
</html>

@kevinsawicki kevinsawicki self-assigned this Nov 9, 2016

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Nov 9, 2016

Member

The best way is to look at the net-log trace.

app.commandLine.appendSwitch('log-net-log', <path-to-dump-net-trace-json>)

Import the file into chrome://net-internals and you should see the error for the request about:blank.

Member

deepak1556 commented Nov 9, 2016

The best way is to look at the net-log trace.

app.commandLine.appendSwitch('log-net-log', <path-to-dump-net-trace-json>)

Import the file into chrome://net-internals and you should see the error for the request about:blank.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 10, 2016

Contributor

@deepak1556 awesome tip, thanks so much 👍

screen shot 2016-11-09 at 4 01 11 pm

Contributor

kevinsawicki commented Nov 10, 2016

@deepak1556 awesome tip, thanks so much 👍

screen shot 2016-11-09 at 4 01 11 pm

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 10, 2016

Contributor

Looks great, thanks 👍

screen shot 2016-11-09 at 4 13 02 pm

Contributor

kevinsawicki commented Nov 10, 2016

Looks great, thanks 👍

screen shot 2016-11-09 at 4 13 02 pm

@kevinsawicki kevinsawicki merged commit 7b46329 into electron:master Nov 10, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 10, 2016

Member

Is this tip worth adding to /docs/tutorial somewhere?

Member

zeke commented Nov 10, 2016

Is this tip worth adding to /docs/tutorial somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment