New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support remove / clear for chrome.storage #7923

Merged
merged 2 commits into from Nov 15, 2016

Conversation

Projects
None yet
3 participants
@jhen0409
Member

jhen0409 commented Nov 10, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 14, 2016

Contributor

Would you mind adding a call to this to the specs so that it is exercised?

chrome.storage.local.get(null, function(localItems) {
callback(syncItems, localItems)
})

assert.deepEqual(message.storageItems, {
local: {hello: 'world'},
sync: {foo: 'bar'}
})

Contributor

kevinsawicki commented Nov 14, 2016

Would you mind adding a call to this to the specs so that it is exercised?

chrome.storage.local.get(null, function(localItems) {
callback(syncItems, localItems)
})

assert.deepEqual(message.storageItems, {
local: {hello: 'world'},
sync: {foo: 'bar'}
})

@jhen0409

This comment has been minimized.

Show comment
Hide comment
@jhen0409

jhen0409 Nov 15, 2016

Member

Would you mind adding a call to this to the specs so that it is exercised?

OK, done. @kevinsawicki please review. :)

Member

jhen0409 commented Nov 15, 2016

Would you mind adding a call to this to the specs so that it is exercised?

OK, done. @kevinsawicki please review. :)

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 15, 2016

Contributor

Great work on the updated specs, thanks for that 👍

Contributor

kevinsawicki commented Nov 15, 2016

Great work on the updated specs, thanks for that 👍

@kevinsawicki kevinsawicki merged commit eeffa42 into electron:master Nov 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment