New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external frameworks version #7933

Merged
merged 2 commits into from Nov 11, 2016

Conversation

Projects
None yet
3 participants
@joshaber
Contributor

joshaber commented Nov 10, 2016

Bump to 1.2.0 which upgraded Squirrel.Mac.

Note that this version of Squirrel.Mac was built with Xcode 7.2.1. This means App Transport Security (ATS) will apply to its requests. ⚠️ This is a potentially breaking change. ⚠️

In the past this was a big problem as S3 failed ATS' checks. S3 now passes (see the output of /usr/bin/nscurl --ats-diagnostics https://s3.amazonaws.com). Apps that still need to disable ATS can add the NSAllowsArbitraryLoads key to their app's plist.

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Nov 10, 2016

Contributor

Could someone with the appropriate permissions restart the Appveyor build? I had the tag wrong initially.

Contributor

joshaber commented Nov 10, 2016

Could someone with the appropriate permissions restart the Appveyor build? I had the tag wrong initially.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 10, 2016

Contributor

Apps that still need to disable ATS can add the NSAllowsArbitraryLoads key to their app's plist.

Worth adding to the docs?

Contributor

kevinsawicki commented Nov 10, 2016

Apps that still need to disable ATS can add the NSAllowsArbitraryLoads key to their app's plist.

Worth adding to the docs?

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Nov 10, 2016

Contributor

Worth adding to the docs?

👍

Contributor

joshaber commented Nov 10, 2016

Worth adding to the docs?

👍

@zeke

zeke approved these changes Nov 11, 2016

@joshaber

This comment has been minimized.

Show comment
Hide comment
@joshaber

joshaber Nov 11, 2016

Contributor

I don't have merge access so someone else will need to merge this 😄

Contributor

joshaber commented Nov 11, 2016

I don't have merge access so someone else will need to merge this 😄

@zeke zeke merged commit ad63809 into electron:master Nov 11, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joshaber joshaber deleted the joshaber:patch-1 branch Nov 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment