Memoize isAsarDisabled because it's called a lot #7948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (process.noAsar) { | ||
| asarDisabled = true |
There was a problem hiding this comment.
process.noAsar is allowed to be changed at runtime so it shouldn't be cached.
| return true | ||
| } | ||
|
|
||
| asarDisabled = true |
There was a problem hiding this comment.
Shouldn't it be set to false if it gets here?
kevinsawicki
changed the title
| if (process.noAsar) { | ||
| asarDisabled = true | ||
| return true | ||
| } | ||
| if (process.env.ELECTRON_NO_ASAR && process.type !== 'browser' && process.type !== 'renderer') { |
There was a problem hiding this comment.
Maybe we can just memoize this instead above this method?
const envNoAsar = process.env.ELECTRON_NO_ASAR && process.type !== 'browser' && process.type !== 'renderer'Then this method could just be
return process.noAsar || envNoAsar
|
Thanks for profiling this, definitely would like to get this fixed and out this week in the next release, 1.4.7, left a few minor comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that on Windows, calling into process.env is not a very snappy operation