New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command #7952

Merged
merged 7 commits into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@the-ress
Contributor

the-ress commented Nov 12, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 15, 2016

Contributor

Thanks for this, would you mind adding a simple spec to spec/api-browser-window-spec.js for this that just verifies it does not crash or throw unexpected errors?

Something like but with valid values for all the supported keys:

it('supports setting the app details', function () {
  assert.doesNotThrow(function () {
    window.setAppDetails({appId: 'my.app.id', relaunchCommand: 'electron'})
    window.setAppDetails({})
  })
})

Also, can you update the docs in docs/browser-window.md with the usage details?

Contributor

kevinsawicki commented Nov 15, 2016

Thanks for this, would you mind adding a simple spec to spec/api-browser-window-spec.js for this that just verifies it does not crash or throw unexpected errors?

Something like but with valid values for all the supported keys:

it('supports setting the app details', function () {
  assert.doesNotThrow(function () {
    window.setAppDetails({appId: 'my.app.id', relaunchCommand: 'electron'})
    window.setAppDetails({})
  })
})

Also, can you update the docs in docs/browser-window.md with the usage details?

@the-ress the-ress changed the title from Added BrowserWindow.setAppId to set user model id, icon and relaunch command to Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command Nov 18, 2016

@the-ress

This comment has been minimized.

Show comment
Hide comment
@the-ress

the-ress Nov 18, 2016

Contributor

Thanks for the suggestions. I've updated those files.

Contributor

the-ress commented Nov 18, 2016

Thanks for the suggestions. I've updated those files.

@kevinsawicki kevinsawicki self-assigned this Nov 23, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 28, 2016

Contributor

Thanks for adding this, apologies for the delay getting it merged 🚢 👍

Contributor

kevinsawicki commented Nov 28, 2016

Thanks for adding this, apologies for the delay getting it merged 🚢 👍

@kevinsawicki kevinsawicki merged commit a739511 into electron:master Nov 28, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@the-ress

This comment has been minimized.

Show comment
Hide comment
@the-ress

the-ress Nov 28, 2016

Contributor

Thanks!

Contributor

the-ress commented Nov 28, 2016

Thanks!

@the-ress the-ress deleted the the-ress:window-setappid branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment