New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize ELECTRON_NO_ASAR env var check #7978

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Nov 15, 2016

The ELECTRON_NO_ASAR var is supported for spawned/forked child processes so it only needs to be checked once and the value can be cached for future calls.

馃悗 Seeks to improve on the costly checks reported in #7948

/cc @paulcbetts 馃憖

Closes #7948

@kevinsawicki kevinsawicki merged commit bee5ced into master Nov 16, 2016

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #4706146 queued
Details
electron-linux-ia32 Build #4706147 queued
Details
electron-linux-x64 Build #4706148 queued
Details

@kevinsawicki kevinsawicki deleted the memoize-no-asar-env-check branch Nov 16, 2016

@paulcbetts

This comment has been minimized.

Show comment
Hide comment
@paulcbetts

paulcbetts Nov 16, 2016

Contributor

馃憤

Contributor

paulcbetts commented Nov 16, 2016

馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment