New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against missing members in setObjectMembers #7980

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Nov 15, 2016

This moves the guard added in #7209 to extend to all cases where setObjectMembers is called.

It has been reported there are still cases where Uncaught TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined errors can occur.

Closes #7918

@kevinsawicki kevinsawicki merged commit 63a138b into master Nov 16, 2016

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #4706166 queued
Details
electron-linux-ia32 Build #4706167 queued
Details
electron-linux-x64 Build #4706168 queued
Details

@kevinsawicki kevinsawicki deleted the guard-against-missing-members branch Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment