New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reload and toggledevtools menu item roles #7981

Merged
merged 4 commits into from Nov 17, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Nov 15, 2016

Noticed these were still being implemented manually in the default app even though they just called a method directly on the focused window.

This pull request adds them as reload and toggledevtools role for less code duplication.

@kevinsawicki kevinsawicki merged commit 02a95a3 into master Nov 17, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4721455 succeeded in 66s
Details
electron-linux-ia32 Build #4721456 succeeded in 58s
Details
electron-linux-x64 Build #4721457 succeeded in 124s
Details
electron-mas-x64 Build #2854 succeeded in 7 min 54 sec
Details
electron-osx-x64 Build #2865 succeeded in 8 min 56 sec
Details
electron-win-ia32 Build #1929 succeeded in 10 min
Details
electron-win-x64 Build #1899 succeeded in 10 min
Details

@kevinsawicki kevinsawicki deleted the more-menu-item-roles branch Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment