New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw custom error when remote object is missing from registry #8003

Merged
merged 3 commits into from Nov 17, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Nov 17, 2016

This pull request replaces the Uncaught Error: Cannot read property 'object' of undefined errors thrown when calling a remote function that is missing from the object registry with custom error messages that include the name of the method/property and the id of the missing object.

These have started cropping up on CI and so this is an attempt to track them down further.

The EBADRPC code is set on the errors:

72 EBADRPC RPC struct is bad. Exchange of RPC information was unsuccessful.

Refs #7351

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 17, 2016

Contributor

Going to merge this to get this running on other pull requests that are failing to see if it gets triggered. Can revert later if necessary.

Contributor

kevinsawicki commented Nov 17, 2016

Going to merge this to get this running on other pull requests that are failing to see if it gets triggered. Can revert later if necessary.

@kevinsawicki kevinsawicki merged commit 28c39d5 into master Nov 17, 2016

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #4719521 succeeded in 64s
Details
electron-linux-ia32 Build #4719522 succeeded in 58s
Details
electron-linux-x64 Build #4719523 succeeded in 125s
Details
electron-mas-x64 Build #2851 succeeded in 8 min 11 sec
Details
electron-osx-x64 Build #2862 succeeded in 8 min 52 sec
Details
electron-win-ia32 Build #1926 succeeded in 10 min
Details
electron-win-x64 Build #1897 succeeded in 10 min
Details

@kevinsawicki kevinsawicki deleted the missing-remote-object-error branch Nov 17, 2016

@wafer-li wafer-li referenced this pull request Nov 23, 2016

Closed

游戏界面没有声音 #1234

@lgeiger lgeiger referenced this pull request Nov 24, 2016

Closed

Random Electron Error #1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment