New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect window size after restore on Windows #8047

Merged
merged 9 commits into from Nov 22, 2016

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Nov 22, 2016

These reverts #7766

It fixes #7630 in a different way and also fixes #7951.

MarshallOfSound added some commits Nov 22, 2016

@MarshallOfSound MarshallOfSound changed the title from Fix incorrect window size to Fix incorrect window size after restore on Windows Nov 22, 2016

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Nov 22, 2016

Member

Please note that lots of these additions are actually just reverting the deletion from c65033a

Member

MarshallOfSound commented Nov 22, 2016

Please note that lots of these additions are actually just reverting the deletion from c65033a

kevinsawicki added some commits Nov 22, 2016

@kevinsawicki kevinsawicki merged commit e356168 into master Nov 22, 2016

6 of 9 checks passed

electron-win-ia32 Build #1960 failed in 11 min
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #4759761 succeeded in 64s
Details
electron-linux-ia32 Build #4759762 succeeded in 60s
Details
electron-linux-x64 Build #4759763 succeeded in 125s
Details
electron-mas-x64 Build #2893 succeeded in 9 min 4 sec
Details
electron-osx-x64 Build #2902 succeeded in 8 min 23 sec
Details
electron-win-x64 Build #1937 succeeded in 10 min
Details

@kevinsawicki kevinsawicki deleted the fix-incorrect-window-size branch Nov 22, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 22, 2016

Contributor

Thanks for this @MarshallOfSound 🏁 🎉

Contributor

kevinsawicki commented Nov 22, 2016

Thanks for this @MarshallOfSound 🏁 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment