New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemPreferences.setUserDefault for macOS #8084

Merged
merged 1 commit into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@poiru
Member

poiru commented Nov 27, 2016

This API can be used to e.g. enable key repeat by setting
ApplePressAndHoldEnabled to false (see also #47).

void SystemPreferences::SetUserDefault(const std::string& name,
const std::string& type,
mate::Arguments* args) {
const auto throwConversionError = [&] {

This comment has been minimized.

@kevinsawicki

kevinsawicki Nov 28, 2016

Contributor

This is cool, we haven't used C++ lambdas so far in Electron but this case seems clear to me and keeps it tidy 👍

@kevinsawicki

kevinsawicki Nov 28, 2016

Contributor

This is cool, we haven't used C++ lambdas so far in Electron but this case seems clear to me and keeps it tidy 👍

@kevinsawicki kevinsawicki self-assigned this Nov 28, 2016

Add systemPreferences.setUserDefault for macOS
This API can be used to e.g. enable key repeat by setting
`ApplePressAndHoldEnabled` to `false` (see also #47).
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 29, 2016

Contributor

Thanks for adding this 👍 🚢

Contributor

kevinsawicki commented Nov 29, 2016

Thanks for adding this 👍 🚢

@kevinsawicki kevinsawicki merged commit 2c8ab72 into electron:master Nov 29, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@poiru poiru deleted the poiru:systempreferences-setuserdefault branch Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment