New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol: support custom session with interceptHttpProtocol #8085

Merged
merged 2 commits into from Dec 12, 2016

Conversation

Projects
None yet
2 participants
@deepak1556
Member

deepak1556 commented Nov 27, 2016

Fixes #8079

Depends on electron/native-mate#7

@kevinsawicki kevinsawicki self-assigned this Dec 12, 2016

@kevinsawicki kevinsawicki merged commit f2aabee into electron:master Dec 12, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Dec 12, 2016

Contributor

@deepak1556 thanks for this 👍

It looks like the spec passed without the native_mate version bumped, does that still need to be pulled in?

Contributor

kevinsawicki commented Dec 12, 2016

@deepak1556 thanks for this 👍

It looks like the spec passed without the native_mate version bumped, does that still need to be pulled in?

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Dec 15, 2016

Member

The native_mate commit is not needed, since I have modified the condition statements.

Member

deepak1556 commented Dec 15, 2016

The native_mate commit is not needed, since I have modified the condition statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment