New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override window.confirm in devtools #8086

Merged
merged 2 commits into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@deepak1556
Member

deepak1556 commented Nov 27, 2016

Result of the operation is required to complete the remove from workspace menu item action in the navigator view. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js?l=649-658

Fixes #7960

@kevinsawicki kevinsawicki self-assigned this Nov 29, 2016

@kevinsawicki kevinsawicki merged commit 477ac31 into electron:master Nov 29, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Nov 29, 2016

Contributor

Thanks for fixing this @deepak1556 👍 🚢

Contributor

kevinsawicki commented Nov 29, 2016

Thanks for fixing this @deepak1556 👍 🚢

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Nov 30, 2016

Member

👍

Member

deepak1556 commented Nov 30, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment