New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add api to clear http auth cache #8107

Merged
merged 6 commits into from Dec 9, 2016

Conversation

Projects
None yet
2 participants
@deepak1556
Member

deepak1556 commented Nov 30, 2016

Fixes #8089

@@ -130,7 +151,27 @@ struct Converter<ClearStorageDataOptions> {
}
};
template<>
template <>

This comment has been minimized.

@kevinsawicki

kevinsawicki Dec 6, 2016

Contributor

Super minor, but looks like most other templates don't have a space before the <>

@kevinsawicki

kevinsawicki Dec 6, 2016

Contributor

Super minor, but looks like most other templates don't have a space before the <>

This comment has been minimized.

@deepak1556

deepak1556 Dec 7, 2016

Member

clang-format returns template <> instead of template<> . But we do have both versions in the source. Not sure what to follow. I would prefer the former, since I mostly run git-clang-format.

@deepak1556

deepak1556 Dec 7, 2016

Member

clang-format returns template <> instead of template<> . But we do have both versions in the source. Not sure what to follow. I would prefer the former, since I mostly run git-clang-format.

This comment has been minimized.

@kevinsawicki

kevinsawicki Dec 9, 2016

Contributor

Oh okay, good to know, either is fine with me 👍

@kevinsawicki

kevinsawicki Dec 9, 2016

Contributor

Oh okay, good to know, either is fine with me 👍

@@ -565,4 +566,60 @@ describe('session module', function () {
w.loadURL(url)
})
})
describe('ses.clearAuthCache(options[, callback])', function () {
it('can clear http auth info from cache', function (done) {

This comment has been minimized.

@kevinsawicki

kevinsawicki Dec 6, 2016

Contributor

It is possible to test the clientCertificate path as well?

@kevinsawicki

kevinsawicki Dec 6, 2016

Contributor

It is possible to test the clientCertificate path as well?

@kevinsawicki kevinsawicki self-assigned this Dec 6, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Dec 9, 2016

Contributor

Thanks for this @deepak1556, rebased this 👍 :shipit:

Contributor

kevinsawicki commented Dec 9, 2016

Thanks for this @deepak1556, rebased this 👍 :shipit:

@kevinsawicki kevinsawicki merged commit dc5b270 into electron:master Dec 9, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment