New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement window methods in main process #8120

merged 6 commits into from Dec 5, 2016


None yet
2 participants

kevinsawicki commented Dec 1, 2016

This pull request switches window.alert/.confirm/.close to be implemented completely in the main process instead of over the remote API. This prevents it from being impacted by #7351 and makes it consistent with how APIs are implemented.

This is not intended to change any of behavior of the current APIs.

  • Implement window.alert via ipcRenderer.sendSync
  • Implement window.confirm via ipcRenderer.sendSync
  • Implement window.close via ipcRenderer.sendSync

@kevinsawicki kevinsawicki changed the title from Implement window.alert/confirm in main process to Implement window methods in main process Dec 1, 2016

@kevinsawicki kevinsawicki merged commit a9d4d9a into master Dec 5, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
electron-linux-arm Build #4847417 succeeded in 62s
electron-linux-ia32 Build #4847418 succeeded in 60s
electron-linux-x64 Build #4847419 succeeded in 128s
electron-mas-x64 Build #2979 succeeded in 7 min 22 sec
electron-osx-x64 Build #2991 succeeded in 8 min 19 sec
electron-win-ia32 Build #2037 succeeded in 10 min
electron-win-x64 Build #2014 succeeded in 11 min

@kevinsawicki kevinsawicki deleted the implement-window-methods-in-main-process branch Dec 5, 2016

@kevinsawicki kevinsawicki referenced this pull request Dec 5, 2016


Backports to 1.3 #8142

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment