New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write back to passed in options object #8123

Merged
merged 1 commit into from Dec 2, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Dec 1, 2016

Currently the options parameter passed to dialog APIs is written to in certain cases to add default values which can lead to unsurprising results in the calling code.

This pull request updates those APIs to not modify any of the specified parameters.

Also removes the CoffeeScript leftovers in dialog.js. ☕️

@kevinsawicki kevinsawicki merged commit 851f490 into master Dec 2, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #4837295 succeeded in 76s
Details
electron-linux-ia32 Build #4837296 succeeded in 61s
Details
electron-linux-x64 Build #4837297 succeeded in 129s
Details
electron-mas-x64 Build #2972 succeeded in 7 min 29 sec
Details
electron-osx-x64 Build #2984 succeeded in 8 min 59 sec
Details
electron-win-ia32 Build #2030 succeeded in 9 min 44 sec
Details
electron-win-x64 Build #2006 succeeded in 9 min 51 sec
Details

@kevinsawicki kevinsawicki deleted the dont-write-back-to-passed-options branch Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment